Fix: removes app sessions from interactive session listing#331
Open
l-mansouri wants to merge 3 commits into
Open
Fix: removes app sessions from interactive session listing#331l-mansouri wants to merge 3 commits into
l-mansouri wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the interactive-session listing to hide “app sessions” (e.g., awsCustomSession, azureCustomSession) from CLI output, and records the fix via version/changelog updates.
Changes:
- Adds an app-session type constant and filters these session types out in
interactive-session list. - Extends session-type display mapping to include app-session types.
- Adds tests and bumps version/changelog for the fix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
cloudos_cli/interactive_session/cli.py |
Applies client-side filtering to remove app sessions from the list output. |
cloudos_cli/interactive_session/interactive_session.py |
Introduces _APP_SESSION_TYPES and maps app session types to a friendly label. |
tests/test_interactive_session/test_list_sessions.py |
Adds tests intended to validate app-session filtering behavior. |
cloudos_cli/_version.py |
Bumps package version. |
CHANGELOG.md |
Adds a changelog entry describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
cloudos_cli/interactive_session/cli.py:214
- Client-side filtering can leave
sessionsempty for the requested page even when later pages contain non-app sessions. Instdoutmode this currently results increate_interactive_session_list_table([])returning early, which prevents the user from navigating to next/prev pages and effectively hides sessions that should still be visible.
sessions = [s for s in sessions if s.get('interactiveSessionType') not in APP_SESSION_TYPES]
# Handle empty results
if len(sessions) == 0:
if filter_status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes app sessions from the list of interactive session.
JIRA
Changes
Tests
BEFORE
AFTER